{"id":"CVE-2024-26935","summary":"scsi: core: Fix unremoved procfs host directory regression","details":"In the Linux kernel, the following vulnerability has been resolved:\n\nscsi: core: Fix unremoved procfs host directory regression\n\nCommit fc663711b944 (\"scsi: core: Remove the /proc/scsi/${proc_name}\ndirectory earlier\") fixed a bug related to modules loading/unloading, by\nadding a call to scsi_proc_hostdir_rm() on scsi_remove_host(). But that led\nto a potential duplicate call to the hostdir_rm() routine, since it's also\ncalled from scsi_host_dev_release(). That triggered a regression report,\nwhich was then fixed by commit be03df3d4bfe (\"scsi: core: Fix a procfs host\ndirectory removal regression\"). The fix just dropped the hostdir_rm() call\nfrom dev_release().\n\nBut it happens that this proc directory is created on scsi_host_alloc(),\nand that function \"pairs\" with scsi_host_dev_release(), while\nscsi_remove_host() pairs with scsi_add_host(). In other words, it seems the\nreason for removing the proc directory on dev_release() was meant to cover\ncases in which a SCSI host structure was allocated, but the call to\nscsi_add_host() didn't happen. And that pattern happens to exist in some\nerror paths, for example.\n\nSyzkaller causes that by using USB raw gadget device, error'ing on\nusb-storage driver, at usb_stor_probe2(). By checking that path, we can see\nthat the BadDevice label leads to a scsi_host_put() after a SCSI host\nallocation, but there's no call to scsi_add_host() in such path. That leads\nto messages like this in dmesg (and a leak of the SCSI host proc\nstructure):\n\nusb-storage 4-1:87.51: USB Mass Storage device detected\nproc_dir_entry 'scsi/usb-storage' already registered\nWARNING: CPU: 1 PID: 3519 at fs/proc/generic.c:377 proc_register+0x347/0x4e0 fs/proc/generic.c:376\n\nThe proper fix seems to still call scsi_proc_hostdir_rm() on dev_release(),\nbut guard that with the state check for SHOST_CREATED; there is even a\ncomment in scsi_host_dev_release() detailing that: such conditional is\nmeant for cases where the SCSI host was allocated but there was no calls to\n{add,remove}_host(), like the usb-storage case.\n\nThis is what we propose here and with that, the error path of usb-storage\ndoes not trigger the warning anymore.","modified":"2026-04-03T13:14:37.090782Z","published":"2024-05-01T05:17:31.445Z","related":["ALSA-2024:8617","ALSA-2025:1067","ALSA-2025:1068","SUSE-SU-2024:2008-1","SUSE-SU-2024:2019-1","SUSE-SU-2024:2135-1","SUSE-SU-2024:2190-1","SUSE-SU-2024:2203-1","SUSE-SU-2024:2894-1","SUSE-SU-2024:2939-1","SUSE-SU-2024:2947-1","SUSE-SU-2024:2973-1","SUSE-SU-2025:02264-1","SUSE-SU-2025:02321-1","SUSE-SU-2025:02322-1","SUSE-SU-2025:02537-1","SUSE-SU-2025:20008-1","SUSE-SU-2025:20028-1","SUSE-SU-2025:20166-1","SUSE-SU-2025:20249-1","SUSE-SU-2026:0473-1"],"database_specific":{"osv_generated_from":"https://github.com/CVEProject/cvelistV5/tree/main/cves/2024/26xxx/CVE-2024-26935.json","cna_assigner":"Linux"},"references":[{"type":"WEB","url":"https://git.kernel.org/stable/c/0053f15d50d50c9312d8ab9c11e2e405812dfcac"},{"type":"WEB","url":"https://git.kernel.org/stable/c/3678cf67ff7136db1dd3bf63c361650db5d92889"},{"type":"WEB","url":"https://git.kernel.org/stable/c/5c2386ba80e779a92ec3bb64ccadbedd88f779b1"},{"type":"WEB","url":"https://git.kernel.org/stable/c/cea234bb214b17d004dfdccce4491e6ff57c96ee"},{"type":"WEB","url":"https://git.kernel.org/stable/c/d4c34782b6d7b1e68d18d9549451b19433bd4c6c"},{"type":"WEB","url":"https://git.kernel.org/stable/c/e293c773c13b830cdc251f155df2254981abc320"},{"type":"WEB","url":"https://git.kernel.org/stable/c/f23a4d6e07570826fe95023ca1aa96a011fa9f84"},{"type":"WEB","url":"https://git.kernel.org/stable/c/f4ff08fab66eb5c0b97e1a24edac052fb40bf5d7"},{"type":"WEB","url":"https://lists.debian.org/debian-lts-announce/2024/06/msg00017.html"},{"type":"ADVISORY","url":"https://github.com/CVEProject/cvelistV5/tree/main/cves/2024/26xxx/CVE-2024-26935.json"},{"type":"ADVISORY","url":"https://nvd.nist.gov/vuln/detail/CVE-2024-26935"},{"type":"PACKAGE","url":"https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git"}],"affected":[{"ranges":[{"type":"GIT","repo":"https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git","events":[{"introduced":"88c3d3bb6469cea929ac68fd326bdcbefcdfdd83"},{"fixed":"0053f15d50d50c9312d8ab9c11e2e405812dfcac"}]},{"type":"GIT","repo":"https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git","events":[{"introduced":"68c665bb185037e7eb66fb792c61da9d7151e99c"},{"fixed":"5c2386ba80e779a92ec3bb64ccadbedd88f779b1"}]},{"type":"GIT","repo":"https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git","events":[{"introduced":"2a764d55e938743efa7c2cba7305633bcf227f09"},{"fixed":"cea234bb214b17d004dfdccce4491e6ff57c96ee"}]},{"type":"GIT","repo":"https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git","events":[{"introduced":"7e0ae8667fcdd99d1756922e1140cac75f5fa279"},{"fixed":"3678cf67ff7136db1dd3bf63c361650db5d92889"}]},{"type":"GIT","repo":"https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git","events":[{"introduced":"be03df3d4bfe7e8866d4aa43d62e648ffe884f5f"},{"fixed":"d4c34782b6d7b1e68d18d9549451b19433bd4c6c"},{"fixed":"e293c773c13b830cdc251f155df2254981abc320"},{"fixed":"f4ff08fab66eb5c0b97e1a24edac052fb40bf5d7"},{"fixed":"f23a4d6e07570826fe95023ca1aa96a011fa9f84"}]},{"type":"GIT","repo":"https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git","events":[{"introduced":"0"},{"last_affected":"73f030d4ef6d1ad17f824a0a2eb637ef7a9c7d51"}]}],"database_specific":{"source":"https://storage.googleapis.com/osv-test-cve-osv-conversion/osv-output/CVE-2024-26935.json"}}],"schema_version":"1.7.5"}