{"id":"GHSA-99p8-9p2c-49j4","summary":"Improper Access Control in Onionshare","details":"Between September 26, 2021 and October 8, 2021, [Radically Open Security](https://www.radicallyopensecurity.com/) conducted a penetration test of OnionShare 2.4, funded by the Open Technology Fund's [Red Team lab](https://www.opentech.fund/labs/red-team-lab/). This is an issue from that penetration test.\n\n- Vulnerability ID: OTF-009\n- Vulnerability type: Improper Access Control\n- Threat level: Low\n\n## Description:\n\nAuthenticated users (or unauthenticated in public mode) can send messages without being visible in the list of chat participants.\n\n## Technical description:\n\nPrerequisites:\n\n- Existing chatroom\n- Access to the chatroom (Public or known Private Key)\n- Either a modified frontend client or manual requests from burp/curl\n\nIf a user opens the chatroom without emitting the join message he will not be present in session.users[x] list. Therefore there is no listing in the frontend and no chat participant knows another party joined the chat. It is still possible to send messages in the chatroom.\n\nIf a user decides to abuse OTF-003 (page 22) he can impersonate messages from existing users; others would not be able to distinguish original and faked messages. This is also a prerequisite for OTF-004 (page 19).\n\n## Impact:\n\nAn adversary with access to the chat environment can send messages to the chat without being visible in the list of chat participants.\n\n## Recommendation:\n\n- Allow chat access only after emission of the join event.\n- Implement proper session handling.","aliases":["CVE-2022-21695","PYSEC-2022-46"],"modified":"2024-10-08T13:15:02.906871Z","published":"2022-01-21T23:20:16Z","database_specific":{"cwe_ids":["CWE-287"],"severity":"MODERATE","github_reviewed":true,"github_reviewed_at":"2022-01-19T19:40:50Z","nvd_published_at":"2022-01-18T22:15:00Z"},"references":[{"type":"WEB","url":"https://github.com/onionshare/onionshare/security/advisories/GHSA-99p8-9p2c-49j4"},{"type":"ADVISORY","url":"https://nvd.nist.gov/vuln/detail/CVE-2022-21695"},{"type":"PACKAGE","url":"https://github.com/onionshare/onionshare"},{"type":"WEB","url":"https://github.com/onionshare/onionshare/releases/tag/v2.5"},{"type":"WEB","url":"https://github.com/pypa/advisory-database/tree/main/vulns/onionshare-cli/PYSEC-2022-46.yaml"}],"affected":[{"package":{"name":"onionshare-cli","ecosystem":"PyPI","purl":"pkg:pypi/onionshare-cli"},"ranges":[{"type":"ECOSYSTEM","events":[{"introduced":"2.3"},{"fixed":"2.5"}]}],"versions":["2.3","2.3.1","2.3.2","2.3.3"],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/01/GHSA-99p8-9p2c-49j4/GHSA-99p8-9p2c-49j4.json"}}],"schema_version":"1.9.0","severity":[{"type":"CVSS_V3","score":"CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:L/I:N/A:N"},{"type":"CVSS_V4","score":"CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:A/VC:L/VI:N/VA:N/SC:N/SI:N/SA:N"}]}